oh wait! I just noticed one thing.

It seems that these commits are not signed with an email address associated with your GitHub account, so when this is merged your account might not be credited in https://github.com/microsoft/LightGBM/graphs/contributors.

I believe that has happened since the commits don't have your profile pic on them.

This probably means you need to set your email address in your ~/.gitconfig to one associated with your GitHub account. See #3607 (comment) and uptake/pkgnet#284 (review) for some tips on how to do that, if you are not familiar with it.

It's not necessary for this PR, we just want to be sure you get credit for your work!

oh wait! I just noticed one thing.

It seems that these commits are not signed with an email address associated with your GitHub account, so when this is merged your account might not be credited in https://github.com/microsoft/LightGBM/graphs/contributors.

I believe that has happened since the commits don't have your profile pic on them.

This probably means you need to set your email address in your ~/.gitconfig to one associated with your GitHub account. See #3607 (comment) and uptake/pkgnet#284 (review) for some tips on how to do that, if you are not familiar with it.

It's not necessary for this PR, we just want to be sure you get credit for your work!

Thanks for the heads up! Had my gitconfig set to a different domain

Thanks for the heads up! Had my gitconfig set to a different domain

no problem! It happens haha

We'll merge this once the CI jobs finish. Thanks again for contributing, and we hope you'll contribute more in the future 🙌

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.